Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement view access permission for Dashboard and Query resources. #2011

Closed
wants to merge 8 commits into from
Closed

Implement view access permission for Dashboard and Query resources. #2011

wants to merge 8 commits into from

Conversation

meinac
Copy link
Contributor

@meinac meinac commented Oct 10, 2017

This feature will be available only if FEATURE_SHOW_PERMISSIONS_CONTROL
and FEATURE_ENABLE_VIEW_PERMISSION flags are set as +True+.
If user has view access to a dashboard objct, all the queries related to
this dashboard will be accessible by the user but the otherway around is
not possible.

@meinac meinac mentioned this pull request Oct 11, 2017
Closed
@arikfr
Copy link
Member

arikfr commented Oct 31, 2017

Thanks! I'll review this once v3 is released (beta should be this week 🤞).

@arikfr arikfr added this to the v4 milestone Oct 31, 2017
@arikfr arikfr modified the milestones: v4, Next Feb 10, 2018
@meinac
Copy link
Contributor Author

meinac commented Mar 19, 2018

@arikfr would you like to merge this into master? Since these changes effect the core of the application, with each new feature, the risk of loosing the track of the code increases.
I would merge this pr ASAP which will be foundation of any other. Please let me know, I'm happy to give any support you need to make this merged.

@RichardLitt RichardLitt requested a review from arikfr March 19, 2018 15:48
@arikfr
Copy link
Member

arikfr commented Mar 22, 2018

Thank you for the follow up, @meinac. I didn't have the chance to properly review this after the v3 release as we dived right into v4 and you're touching some areas that require careful thought and review.

There are security implications here that need to be reviewed properly, but also I feel that there are few product aspects that we need to think about in a more "holistic" way to make sure we don't apply a patch that will be hard to replace later on.

Now that v4 is almost done (just fixing few last issues -- mainly #2406), the new knowledge base is out, I'm getting more time to think about this. I will give it some thought and then share with you and the community to discuss the way forward and how this pull request fits in.

How's that sound?

@luisnunezsalgado
Copy link

Anyone with write permissions, could generate the merge and inclusion of the changes into the main branch of source code ? please

@meinac meinac force-pushed the implement_view_permissions branch from b31b5f4 to d75265f Compare June 28, 2018 13:18
majofi and others added 5 commits July 3, 2018 15:18
@majofi @meinac
Implement view access permission for Dashboard and Query resources.
6327860 
This feature will be available only if `FEATURE_SHOW_PERMISSIONS_CONTROL`
and `FEATURE_ENABLE_VIEW_PERMISSION` flags are set as +True+.
If user has view access to a dashboard objct, all the queries related to
this dashboard will be accessible by the user but the otherway around is
not possible.
@meinac
Fix recent queries list
ce185f8
@meinac
Fix recent queries
c152d67
@meinac
Admins can see everything
efce3db
@meinac
Fix query list pagination
dbcb2f7
@meinac meinac force-pushed the implement_view_permissions branch from 3ec3259 to dbcb2f7 Compare July 4, 2018 15:40
@arikfr
Copy link
Member

arikfr commented Jan 15, 2019

Thanks, @meinac for your contribution. Unfortunately I'm going to close this now. We decided to invest some time to solve the use cases around sharing data in Redash in a more holistic way, including addressing issues with sharing queries with parameters. To follow along you can watch #3284.

@arikfr arikfr closed this Jan 15, 2019
@bun4uk
Copy link

bun4uk commented Mar 17, 2023

Hi there! It's 2023 and there is still no way to give access to a specific dashboard to a specific group or user ://

@calloquy-mark-baker
Copy link

Thanks, @meinac for your contribution. Unfortunately I'm going to close this now. We decided to invest some time to solve the use cases around sharing data in Redash in a more holistic way, including addressing issues with sharing queries with parameters. To follow along you can watch #3284.

@arikfr Do you have any thoughts on when this might be implemented? Would love to utilize Redash more holistically within our org but would require user or group level permissions for dashboards. Thanks for all the hard work!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikfr arikfr Awaiting requested review from arikfr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@meinac @arikfr @luisnunezsalgado @bun4uk @calloquy-mark-baker @majofi